Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CYPRESS : fix logout cypress issue #14917

Merged
merged 2 commits into from
Jan 29, 2024
Merged

CYPRESS : fix logout cypress issue #14917

merged 2 commits into from
Jan 29, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues e2e This will trigger e2e test workflows labels Jan 29, 2024
@Ashish8689 Ashish8689 self-assigned this Jan 29, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 29, 2024
@Ashish8689 Ashish8689 added e2e This will trigger e2e test workflows and removed e2e This will trigger e2e test workflows labels Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
 53.21% (27306/51314) 35.23% (10898/30930) 34.02% (3195/9392)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 29, 2024

3 failed tests on run #33089 ↗︎

3 688 12 0 Flakiness 0

Details:

minor fix
Project: openmetadata Commit: bebfef3150
Status: Failed Duration: 37:50 💡
Started: Jan 29, 2024 7:49 AM Ended: Jan 29, 2024 8:27 AM
Failed  cypress/e2e/Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-psql-oss-7692605122-1

View Output Video

Test Artifacts
Snowflake Ingestion > Create & Ingest Snowflake service Screenshots Video
Snowflake Ingestion > Update description and verify description after re-run Screenshots Video
Snowflake Ingestion > Delete Snowflake service Screenshots Video

Review all test suite changes for PR #14917 ↗︎

@Ashish8689 Ashish8689 merged commit aeb23f8 into main Jan 29, 2024
27 of 40 checks passed
@Ashish8689 Ashish8689 deleted the logout-cypress branch January 29, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya