Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding unit tests #14996

Merged
merged 19 commits into from
Feb 6, 2024
Merged

adding unit tests #14996

merged 19 commits into from
Feb 6, 2024

Conversation

Abhishek332
Copy link
Contributor

@Abhishek332 Abhishek332 commented Feb 1, 2024 •
edited
Loading

this PR contains unit test for -

  • components/Alerts/AlertsDetails
  • components/AppTour
  • components/Modals/TourEndModal
  • components/Applications/AppDetails
  • components/Applications/AppInstallVerifyCard
  • components/Applications/AppLogsViewer
  • components/Applications/AppRunsHistory
  • components/Applications/AppSchedule
  • components/Applications/MarketPlaceAppDetails
Screenshot 2024-02-01 at 3 04 59 PM Screenshot 2024-02-01 at 5 35 27 PM Screenshot 2024-02-01 at 6 04 12 PM Screenshot 2024-02-02 at 4 48 02 PM Screenshot 2024-02-02 at 9 10 41 PM Screenshot 2024-02-02 at 9 09 46 PM Screenshot 2024-02-05 at 3 10 40 PM Screenshot 2024-02-05 at 6 19 52 PM Screenshot 2024-02-06 at 9 07 54 AM

@Abhishek332 Abhishek332 marked this pull request as draft February 1, 2024 16:17
@github-actions github-actions bot added the UI UI specific issues label Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@karanh37 karanh37 added the safe to test Add this label to run secure Github workflows on PRs label Feb 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 54%
 54.94% (28485/51843) 36.86% (11504/31210) 35.6% (3383/9502)

Abhishek332 and others added 16 commits February 2, 2024 16:48
@Abhishek332 Abhishek332 marked this pull request as ready for review February 6, 2024 05:45
Sachin-chaurasiya
Sachin-chaurasiya reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks

openmetadata-ui/src/main/resources/ui/src/components/Alerts/AlertsDetails/AlertDetails.test.tsx Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/Alerts/AlertsDetails/AlertDetails.test.tsx Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit 595798a into open-metadata:main Feb 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhishek332 @Sachin-chaurasiya @karanh37