Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format cron from quartz to unix in applications #15038

Merged
merged 11 commits into from
Feb 9, 2024
Merged

format cron from quartz to unix in applications #15038

merged 11 commits into from
Feb 9, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 5, 2024 •
edited
Loading

Describe your changes:

Backed issue :- #15067

  • change quartx cron to unix in applications.
  • fix default fields in while edit and install in application.

Resolved :

Screen.Recording.2024-02-07.at.7.07.52.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues e2e This will trigger e2e test workflows labels Feb 5, 2024
@Ashish8689 Ashish8689 self-assigned this Feb 5, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 5, 2024
@chirag-madlani chirag-madlani marked this pull request as draft February 5, 2024 14:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 58%
 58.74% (30133/51301) 39.05% (12101/30991) 38.75% (3676/9487)

@Ashish8689 Ashish8689 marked this pull request as ready for review February 6, 2024 09:16
@Sachin-chaurasiya
Copy link
Member

@Ashish8689 , can you check why we don't have the week option as the selected one?

image

@Ashish8689 Ashish8689 marked this pull request as draft February 7, 2024 06:17
chirag-madlani
chirag-madlani previously approved these changes Feb 9, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 847b2d8 into main Feb 9, 2024
16 of 18 checks passed
@chirag-madlani chirag-madlani deleted the application-inital-value branch February 9, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @Sachin-chaurasiya @chirag-madlani