Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui): unit tests for users tab and user profile icon component #15053

Merged
merged 11 commits into from
Feb 7, 2024
Merged

test(ui): unit tests for users tab and user profile icon component #15053

merged 11 commits into from
Feb 7, 2024

Conversation

harsh-vador
Copy link
Contributor

@harsh-vador harsh-vador commented Feb 6, 2024 •
edited
Loading

Describe your changes:

I worked on adding unit test cases for below components:

  • components/Users/UserProfileIcon
  • components/Users/UsersTab

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harsh-vador harsh-vador changed the title Add Unit test case [WIP] Add Unit test case Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harsh-vador harsh-vador marked this pull request as ready for review February 6, 2024 18:38
@harsh-vador harsh-vador changed the title [WIP] Add Unit test case [WIP] Add Unit test cases Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harsh-vador harsh-vador changed the title [WIP] Add Unit test cases Add Unit test cases Feb 7, 2024
@karanh37 karanh37 added the safe to test Add this label to run secure Github workflows on PRs label Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 57%
 57.22% (29680/51868) 38.27% (11947/31218) 37.61% (3574/9504)

@chirag-madlani chirag-madlani changed the title Add Unit test cases test(ui): unit tests for users tab and user profile icon component Feb 7, 2024
Sachin-chaurasiya
Sachin-chaurasiya reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks

...-ui/src/main/resources/ui/src/components/Users/UserProfileIcon/UserProfileIcon.component.tsx Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/Users/UserProfileIcon/UserProfileIcon.test.tsx Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/Users/UserProfileIcon/UserProfileIcon.test.tsx Outdated Show resolved Hide resolved
@Sachin-chaurasiya Sachin-chaurasiya enabled auto-merge (squash) February 7, 2024 10:21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit d4ac43d into open-metadata:main Feb 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harsh-vador @chirag-madlani @Sachin-chaurasiya @karanh37