Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix ingestion pipeline name search not working for observability alert #15057

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Minor: Fix ingestion pipeline name search not working for observability alert #15057

merged 5 commits into from
Feb 6, 2024

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Feb 6, 2024 •
edited by mohityadav766
Loading

I worked on fixing the ingestion pipeline search by name not working properly while observability alert creation

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 requested a review from a team February 6, 2024 11:55
@aniketkatkar97 aniketkatkar97 self-assigned this Feb 6, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 54%
 54.94% (28485/51843) 36.86% (11504/31210) 35.6% (3383/9502)

pmbrull
pmbrull previously approved these changes Feb 6, 2024
View reviewed changes
@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review February 6, 2024 13:15
@aniketkatkar97 aniketkatkar97 added the e2e This will trigger e2e test workflows label Feb 6, 2024
Sachin-chaurasiya
Sachin-chaurasiya approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes looks good.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mohityadav766 mohityadav766 merged commit b871369 into main Feb 6, 2024
35 of 41 checks passed
@mohityadav766 mohityadav766 deleted the fix-ingestion-pipeline-options branch February 6, 2024 14:00
mohityadav766 pushed a commit that referenced this pull request Feb 6, 2024
@aniketkatkar97 @mohityadav766
Minor: Fix ingestion pipeline name search not working for observabili…
7a646b4 
…ty alert (#15057)

* add ingestion pipeline search index in UI

* Add Ingestion Pipeline index

* Update date in case of running

* Use timestamp

* add cypress test case for ingestion pipeline trigger

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
(cherry picked from commit b871369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@pmbrull pmbrull Awaiting requested review from pmbrull

Assignees

@aniketkatkar97 aniketkatkar97

Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aniketkatkar97 @chirag-madlani @pmbrull @Sachin-chaurasiya @mohityadav766