Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Cypress improvements and flakiness fixes #15068

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Minor: Cypress improvements and flakiness fixes #15068

merged 8 commits into from
Feb 7, 2024

Conversation

aniketkatkar97
Copy link
Member

I worked on improving and fixing flaky cypress tests for:

  • ObservabilityAlert
  • NotificationsAlert
  • GlossaryVersionPage
  • SearchIndexDetailsPage

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added the e2e This will trigger e2e test workflows label Feb 7, 2024
@aniketkatkar97 aniketkatkar97 requested a review from a team February 7, 2024 06:35
@aniketkatkar97 aniketkatkar97 self-assigned this Feb 7, 2024
@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review February 7, 2024 06:35
@github-actions github-actions bot added the UI UI specific issues label Feb 7, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 56%
 56.94% (29529/51862) 37.81% (11800/31212) 37.27% (3542/9504)

@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner February 7, 2024 10:15
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 38f24fc into main Feb 7, 2024
23 of 25 checks passed
@chirag-madlani chirag-madlani deleted the cypress-flaky-fix branch February 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@aniketkatkar97 aniketkatkar97

Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aniketkatkar97 @chirag-madlani @Sachin-chaurasiya @mohityadav766