Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - fix(prerequisite): add check for bash version #15103

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Feb 8, 2024

Describe your changes:

Fixes this error when running the prerequisite target:

bash-3.2$ make prerequisites
Makefile:144: warning: overriding commands for target `build-ingestion-base-local'
Makefile:139: warning: ignoring old commands for target `build-ingestion-base-local'
./scripts/check_prerequisites.sh
./scripts/check_prerequisites.sh: line 15: declare: -A: invalid option
declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
make: *** [prerequisites] Error 2

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 8, 2024
@pmbrull pmbrull merged commit c9aa6aa into main Feb 9, 2024
11 checks passed
@pmbrull pmbrull deleted the add-bash-prerequisite branch February 9, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants