Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix glossary version cypress for AUT #15114

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Minor: Fix glossary version cypress for AUT #15114

merged 3 commits into from
Feb 9, 2024

Conversation

aniketkatkar97
Copy link
Member

I worked on fixing the glossary version cypress for AUT

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues e2e This will trigger e2e test workflows labels Feb 9, 2024
@aniketkatkar97 aniketkatkar97 requested a review from a team February 9, 2024 07:05
@aniketkatkar97 aniketkatkar97 self-assigned this Feb 9, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 59%
 59.47% (30502/51294) 39.57% (12267/31001) 39.29% (3728/9488)

@aniketkatkar97 aniketkatkar97 marked this pull request as draft February 9, 2024 13:42
@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review February 9, 2024 14:15
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit b996f2f into main Feb 9, 2024
17 of 19 checks passed
@chirag-madlani chirag-madlani deleted the fix-glossary-version-cypress branch February 9, 2024 16:36
sushi30 pushed a commit to sushi30/OpenMetadata that referenced this pull request Feb 12, 2024
@aniketkatkar97 @sushi30
Minor: Fix glossary version cypress for AUT (open-metadata#15114)
2dd8680 
* fix glossary version cypress for AUT

* remove the unnecessary deletion in cypress test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@aniketkatkar97 aniketkatkar97

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aniketkatkar97 @chirag-madlani @ShaileshParmar11