Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added re-run search indexing banner for es exception on explore page #15120

Merged
merged 6 commits into from
Feb 12, 2024
Merged

added re-run search indexing banner for es exception on explore page #15120

merged 6 commits into from
Feb 12, 2024

Conversation

Abhishek332
Copy link
Contributor

@Abhishek332 Abhishek332 commented Feb 9, 2024 •
edited
Loading

Describe your change:

We are now showing the re-run search indexing banner on explore page for es exception.

Remaining

We have to figure out how we have to show the flow for re-indexing if es exception get on other pages.

Screenshot 2024-02-12 at 12 47 34 PM

@github-actions github-actions bot added the UI UI specific issues label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani marked this pull request as draft February 9, 2024 10:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@Abhishek332 Abhishek332 changed the title added re-run search indexing banner for es exception added re-run search indexing banner for es exception on explore page Feb 12, 2024
@Abhishek332 Abhishek332 marked this pull request as ready for review February 12, 2024 07:14
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@ShaileshParmar11 ShaileshParmar11 added the safe to test Add this label to run secure Github workflows on PRs label Feb 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 60%
 60.63% (31104/51301) 40.07% (12430/31021) 40.18% (3812/9488)

@Sachin-chaurasiya Sachin-chaurasiya enabled auto-merge (squash) February 12, 2024 09:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit b3401a3 into open-metadata:main Feb 12, 2024
14 checks passed
@Abhishek332 Abhishek332 deleted the banner-on-es-exception branch February 12, 2024 11:25
karanh37 pushed a commit that referenced this pull request Feb 22, 2024
@Abhishek332 @karanh37
added re-run search indexing banner for es exception on explore page (#…
66d6745 
…15120)

* added re-run search indexing banner for es exception

* minor change

(cherry picked from commit b3401a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 karanh37 approved these changes

@harshach harshach Awaiting requested review from harshach

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abhishek332 @karanh37 @ShaileshParmar11 @Sachin-chaurasiya