Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - OpenMetadata OPS to load collate-service jars first #15143

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Feb 12, 2024

Describe your changes:

Fixes https://github.com/open-metadata/openmetadata-collate/issues/315

❯ sh openmetadata-ops.sh deploy-pipelines
Deploying Pipelines
Instantiating the Argo Service Client with server [https://localhost:2746], namespace [argo], image [openmetadata/ingestion-base:1.0.0-alpha]
Failed to deploy pipeline OpenMetadata_dataInsight of type dataInsight for service OpenMetadata
com.google.gson.JsonIOException: Failed making field 'java.time.Instant#seconds' accessible; either increase its visibility or write a custom TypeAdapter for its declaring type.

After this update:

❯ ./openmetadata-ops.sh deploy-pipelines
Deploying Pipelines
Instantiating the Argo Service Client with server [https://localhost:2746], namespace [argo], image [openmetadata/ingestion-base:1.0.0-alpha]
+--------------------------+-------------+--------------+--------+
| Name                     | Type        | Service Name | Status |
+--------------------------+-------------+--------------+--------+
| OpenMetadata_dataInsight | dataInsight | OpenMetadata | true   |
| red_metadata_TBk2z3a1    | metadata    | red          | true   |
| red_usage                | usage       | red          | true   |
+--------------------------+-------------+--------------+--------+

The idea is that in Collate we override some internal JSON classes. By loading Collate jars first in the classpath, those updated definitions take precedence when casting the types

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 12, 2024
@pmbrull pmbrull requested a review from a team February 12, 2024 08:32
@pmbrull pmbrull merged commit aaa649a into open-metadata:main Feb 12, 2024
12 of 13 checks passed
sushi30 pushed a commit to sushi30/OpenMetadata that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants