Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13790: Cost analysis Data Insights Optimisations #15147

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

OnkarVO7
Copy link
Contributor

Describe your changes:

Fixes #13790

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 12, 2024
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@OnkarVO7 OnkarVO7 marked this pull request as ready for review February 13, 2024 07:02
@OnkarVO7 OnkarVO7 requested a review from a team as a code owner February 13, 2024 07:02
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OnkarVO7 thanks for the PR. Should we add a way to clear that entity_cache once it is not needed (i.e. we finished processing the cost analysis part of things). Otherwise we'll keep these data for the whole lifecycle of the DI workflow. wdyt?

@OnkarVO7
Copy link
Contributor Author

@OnkarVO7 thanks for the PR. Should we add a way to clear that entity_cache once it is not needed (i.e. we finished processing the cost analysis part of things). Otherwise we'll keep these data for the whole lifecycle of the DI workflow. wdyt?

Yes that makes sense let me clean up the cache once it is not needed

@OnkarVO7 OnkarVO7 requested a review from TeddyCr February 13, 2024 09:52
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
1 New issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OnkarVO7 OnkarVO7 merged commit ecdcf51 into main Feb 15, 2024
11 checks passed
@OnkarVO7 OnkarVO7 deleted the cost_analysis_op branch February 15, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise Data Insights: Cost Analysis
2 participants