Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR - DQ incident severity classifier #15149

Merged
merged 4 commits into from
Feb 13, 2024
Merged

MINOR - DQ incident severity classifier #15149

merged 4 commits into from
Feb 13, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Feb 12, 2024

Describe your changes:

  • Implement a pre-trained logistic regression classifier for severity incident classification.
  • Implement logic for users to provide their own classifier model using OM config file

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

New feature

  • The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion
    or decision-making process is reflected in the issue.
  • I have updated the documentation.
  • I have added tests around the new logic.

@TeddyCr TeddyCr requested a review from a team as a code owner February 12, 2024 11:34
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 12, 2024
pmbrull
pmbrull approved these changes Feb 12, 2024
View reviewed changes
...ta/service/util/incidentSeverityClassifier/LogisticRegressionIncidentSeverityClassifier.java
new double[] {-39.7199427, -3.16664212, 7.52955733, 16.7600252, 18.5970022},
new double[] {65.6563864, 9.33015912, -3.11353307, -13.7841793, -58.0888332},
new double[] {0.0102508192, 0.00490356651, -0.00162766138, -0.00622724217, -0.0072994822},
new double[] {0.0784018717, -0.01140259, -0.00911123152, -0.0237962385, -0.0340918118},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super curious on how you computed this model. It can very well become a medium article!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pmbrull pmbrull merged commit e6cacb1 into open-metadata:main Feb 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
backend data quality Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeddyCr @pmbrull