ISSUE-15100: add tooltip for field Text type #15159
Conversation
Alexandr-Nedomets
requested review from
harshach,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
There was a problem hiding this comment.
Thanks @Alexandr-Nedomets for the PR, i have left a few comments please let me know if you need any help! also, it would be great if you attach a video of your changes in the description
| @@ -74,6 +74,7 @@ const TestCaseForm: React.FC<TestCaseFormProps> = ({ | |||
| const isColumnFqn = dashboardType === ProfilerDashboardType.COLUMN; | |||
| const [form] = Form.useForm(); | |||
| const [testDefinitions, setTestDefinitions] = useState<TestDefinition[]>([]); | |||
| const [testDefinition, setTestDefinition] = useState<TestDefinition>({} as TestDefinition); | |||
There was a problem hiding this comment.
| const [testDefinition, setTestDefinition] = useState<TestDefinition>({} as TestDefinition); | |
| const [testDefinition, setTestDefinition] = useState<TestDefinition>(); |
| onChange={(value) => { | ||
| setTestDefinition( | ||
| testDefinitions.find((item) => item.fullyQualifiedName === value) as TestDefinition | ||
| ); | ||
| }}> |
There was a problem hiding this comment.
it would be great if we pull out the inline function to separate function in the code with below changes
| onChange={(value) => { | |
| setTestDefinition( | |
| testDefinitions.find((item) => item.fullyQualifiedName === value) as TestDefinition | |
| ); | |
| }}> | |
| onChange={(value) => { | |
| setTestDefinition( | |
| testDefinitions.find((item) => item.fullyQualifiedName === value) | |
| ); | |
| }}> |
ShaileshParmar11
added
the
safe to test
Jest test CoverageUI tests summary
|
|
Describe your changes:
Fixes
Add tooltip for field "Test type". Text(value from field description) in tooltip will change depend choose Test type.
Sometime comfortably get tooltip for native language
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>