fix mention list in announcements #15194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-vador
requested review from
harshach,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
karanh37
added
the
safe to test
Jest test CoverageUI tests summary
|
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
4 failed tests on run #33179 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data Insight settings page should work properly > Install application |
Screenshots
Video
|
|
| Data Insight settings page should work properly > Deploy & run application |
Screenshots
Video
|
|
Pages/SearchIndexApplication.spec.ts • 1 failed test • cypress-ci-psql-oss-7928293507-1
| Test | Artifacts | |
|---|---|---|
| Search Index Application > Edit application |
Screenshots
Video
|
|
Flow/Explore.spec.js • 1 failed test • cypress-ci-psql-oss-7928293507-1
| Test | Artifacts | |
|---|---|---|
| Explore Page > should verify order of search results |
Screenshots
Video
|
|
Review all test suite changes for PR #15194 ↗︎
|
chirag-madlani
approved these changes
Feb 16, 2024
Sachin-chaurasiya
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 5eda139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #15131
I worked on fixing the mention list in announcement drawer since earlier it didn't allow to mention users.
Screen.Recording.2024-02-15.at.5.21.01.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>