chore(ui): organise component directory structure #15199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
chirag-madlani
requested review from
harshach,
karanh37 and
Sachin-chaurasiya
as code owners
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
|
karanh37
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
We should name the parent folder as DataInsight instead of DataInsightDetail, following same naming convention as other folder
There was a problem hiding this comment.
I suggest we should keep one folder for TestSuites instead of 2 folder (TestSuite & TestSuites)
There was a problem hiding this comment.
TableProfiler folder should be part of Profiler, also some files are lying without the folders
There was a problem hiding this comment.
Files without folder will leave for individual to update I just reorg them to their parent folder for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>