Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#15188): Ingestion Pipeline Run response #15202

Merged
merged 2 commits into from
Feb 16, 2024
Merged

fix(#15188): Ingestion Pipeline Run response #15202

merged 2 commits into from
Feb 16, 2024

Conversation

Sachin-chaurasiya
Copy link
Contributor

Describe your changes:

Fixes #15188

I worked on issue #15188

Type of change:

  • Bug fix
  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Feb 15, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 61.53% (31406/51045) 40.5% (12516/30900) 40.87% (3859/9441)

@Sachin-chaurasiya Sachin-chaurasiya added the e2e This will trigger e2e test workflows label Feb 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Feb 16, 2024

2 failed tests on run #33176 ↗︎

2 707 12 0 Flakiness 0

Details:

Merge branch 'main' into issue-#15188
Project: openmetadata Commit: 954cda5278
Status: Failed Duration: 39:03 💡
Started: Feb 16, 2024 5:45 AM Ended: Feb 16, 2024 6:24 AM
Failed  Pages/SearchIndexApplication.spec.ts • 1 failed test • cypress-ci-psql-oss-7926459620-1

View Output Video

Test Artifacts
Search Index Application > Edit application Screenshots Video
Failed  Flow/Explore.spec.js • 1 failed test • cypress-ci-psql-oss-7926459620-1

View Output Video

Test Artifacts
Explore Page > should verify order of search results Screenshots Video

Review all test suite changes for PR #15202 ↗︎

chirag-madlani
chirag-madlani reviewed Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sachin-chaurasiya will be great to have tests around the same

@Sachin-chaurasiya Sachin-chaurasiya merged commit 7009fb7 into main Feb 16, 2024
15 of 18 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the issue-#15188 branch February 16, 2024 08:18
@Sachin-chaurasiya
Copy link
Contributor Author

@Sachin-chaurasiya will be great to have tests around the same

@chirag-madlani , we already have cypress tests for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani left review comments

@karanh37 karanh37 karanh37 approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI - Ingestion Pipeline Run response
3 participants
@Sachin-chaurasiya @chirag-madlani @karanh37