Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Updated put with patch call in ui and clean up #15244

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Minor: Updated put with patch call in ui and clean up #15244

merged 5 commits into from
Feb 20, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Feb 19, 2024 •
edited
Loading

Describe your changes:

  • Updated put request with patch
  • removed unused code

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Integration e2e:Governance e2e:Observability safe to test Add this label to run secure Github workflows on PRs and removed UI UI specific issues labels Feb 19, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Feb 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 61.58% (31404/51001) 40.47% (12505/30902) 40.99% (3862/9422)

@ShaileshParmar11 ShaileshParmar11 added the e2e This will trigger e2e test workflows label Feb 20, 2024
@cypress Cypress
Copy link

cypress bot commented Feb 20, 2024 •
edited
Loading

4 failed tests on run #33188 ↗︎

4 716 12 0 Flakiness 0

Details:

Merge branch 'main' into update-put-with-patch
Project: openmetadata Commit: 578ccdbff9
Status: Failed Duration: 38:38 💡
Started: Feb 20, 2024 9:52 AM Ended: Feb 20, 2024 10:31 AM
Failed  Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-psql-oss-7971296077-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video
Superset Ingestion > Update schedule options and verify Screenshots Video
Superset Ingestion > Delete Superset service Screenshots Video
Failed  Flow/Explore.spec.js • 1 failed test • cypress-ci-psql-oss-7971296077-1

View Output Video

Test Artifacts
Explore Page > should verify order of search results Screenshots Video

Review all test suite changes for PR #15244 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit a35c8b3 into main Feb 20, 2024
15 of 18 checks passed
@chirag-madlani chirag-madlani deleted the update-put-with-patch branch February 20, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e:Governance e2e:Integration e2e:Observability e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani