Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude tags search from domain #15328

Merged
merged 3 commits into from
Feb 27, 2024
Merged

exclude tags search from domain #15328

merged 3 commits into from
Feb 27, 2024

Conversation

karanh37
Copy link
Contributor

Describe your changes:

Fixes #15298

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Feb 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 62.1% (31781/51175) 40.49% (12484/30835) 41.24% (3891/9434)

@cypress Cypress
Copy link

cypress bot commented Feb 23, 2024 •
edited
Loading

12 failed tests on run #33208 ↗︎

12 0 720 0 Flakiness 0

Details:

Merge branch 'main' into issue-15298
Project: openmetadata Commit: 38cdb10f1b
Status: Failed Duration: 07:07 💡
Started: Feb 26, 2024 3:16 PM Ended: Feb 26, 2024 3:23 PM
Failed  Pages/EntityVersionPages.spec.js • 7 failed tests • cypress-ci-mysql-pr-oss-8050899325-1

View Output Video

Test Artifacts
Version page tests for data assets > Table version page should work properly > Table version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Topic version page should work properly > Topic version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Dashboard version page should work properly > Dashboard version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Pipeline version page should work properly > Pipeline version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > ML Model version page should work properly > ML Model version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Container version page should work properly > Container version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Search Index version page should work properly > Search Index version page should show changes after soft deleted Screenshots Video
Failed  Flow/SearchFlow.spec.js • 3 failed tests • cypress-ci-mysql-pr-oss-8050899325-1

View Output Video

Test Artifacts
Advance search > Single filed search > Verify advance search results for Column field and all condition Screenshots Video
Advance search > Group search > Verify Add group functionality for All with OR operator & condition Contains and Not contains Screenshots Video
Advance search > Search with additional rule > Verify Add Rule functionality for All with OR operator & condition Contains and Not contains Screenshots Video
Failed  Pages/Glossary.spec.js • 1 failed test • cypress-ci-mysql-pr-oss-8050899325-1

View Output Video

Test Artifacts
Glossary page should work properly > Delete glossary should work properly Screenshots Video
Failed  Flow/CustomizeLandingPage.spec.js • 1 failed test • cypress-ci-mysql-pr-oss-8050899325-1

View Output Video

Test Artifacts
Customize Landing Page Flow > Resetting the layout flow should work properly Screenshots Video

Review all test suite changes for PR #15328 ↗︎

@karanh37 karanh37 marked this pull request as draft February 26, 2024 12:32
@karanh37 karanh37 marked this pull request as ready for review February 26, 2024 12:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit e8c0b01 into main Feb 27, 2024
14 of 16 checks passed
@chirag-madlani chirag-madlani deleted the issue-15298 branch February 27, 2024 08:53
karanh37 added a commit that referenced this pull request Feb 27, 2024
@karanh37
exclude tags search from domain (#15328)
8d9975b 
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
(cherry picked from commit e8c0b01)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't add tags to glossary terms when I am navigating with a selected Domain
2 participants
@karanh37 @chirag-madlani