Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable updation of mutually exclusive in classification and minor other fixes #15361

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Disable updation of mutually exclusive in classification and minor other fixes #15361

merged 4 commits into from
Feb 27, 2024

Conversation

karanh37
Copy link
Contributor

Describe your changes:

Fixes #15357
Fixes #14992

I worked on ... because ...

Screenshot 2024-02-27 at 1 08 11 PM
Screenshot 2024-02-27 at 12 19 31 PM
Screenshot 2024-02-27 at 12 21 22 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added e2e:Governance UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Feb 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 62.1% (31781/51175) 40.49% (12482/30828) 41.25% (3891/9432)

@cypress Cypress
Copy link

cypress bot commented Feb 27, 2024 •
edited
Loading

Passing run #33218 ↗︎

0 26 0 0 Flakiness 0

Details:

Merge branch 'main' into issue-15357
Project: openmetadata Commit: e2e6772b16
Status: Passed Duration: 05:00 💡
Started: Feb 27, 2024 10:48 AM Ended: Feb 27, 2024 10:53 AM

Review all test suite changes for PR #15361 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
2 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit da926d1 into main Feb 27, 2024
16 checks passed
@chirag-madlani chirag-madlani deleted the issue-15357 branch February 27, 2024 11:56
karanh37 added a commit that referenced this pull request Feb 27, 2024
@karanh37
Disable updation of mutually exclusive in classification and minor ot…
3f3bdb6 
…her fixes (#15361)

* fix minor issues of classification and glossary assets

* add mutually exclusive label

* fix cypress

(cherry picked from commit da926d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
e2e:Governance safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable changing of mutually exclusive for classifications UI bug in glossary terms
2 participants
@karanh37 @chirag-madlani