Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11951 [backend] - Implement Profiler Global Config #15889

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Apr 15, 2024

Describe your changes:

Add Global config for the profiler allowing admin to set globally the metrics to be computed based on the dtype or to completely disanle metric computation for a specific dtype

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@TeddyCr TeddyCr requested a review from a team as a code owner April 15, 2024 08:31
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Apr 15, 2024
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TeddyCr TeddyCr merged commit 8d377f5 into open-metadata:main Apr 16, 2024
11 of 13 checks passed
ulixius9 pushed a commit that referenced this pull request Apr 22, 2024
* feat: add global metric configuration for the profiler

* style: ran java linting

* fix: renamed disable to disabled

* style: ran java linting

* fix: json schema profiler config title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion profiler safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants