-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Small refactor to the Make update_all scripts #16204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
Ingestion
safe to test
Add this label to run secure Github workflows on PRs
labels
May 9, 2024
pmbrull
previously approved these changes
May 9, 2024
…adata into improve-deployment-process
pmbrull
previously approved these changes
May 10, 2024
tutte
previously approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, much cleaner, easier to read and to expand. Thanks @IceS2
tutte
approved these changes
May 10, 2024
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
update_version.py
script to make it clearerRELEASE_VERSION
instea ofRELEASE_VERSION
,MVN_RELEASE_VERSION
andPY_RELEASE_VERSION
since we are not doing InPlace releases.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>