Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Small refactor to the Make update_all scripts #16204

Merged
merged 6 commits into from
May 10, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented May 9, 2024

Describe your changes:

  • Refactored update_version.py script to make it clearer
  • Extracted common steps from the release github actions workflows to composite github actions.
  • Decoupled the creation of the Release on Github from the execution of the Workflows since they will be triggered programatically from the Release Automation.
  • Updated Makefile to use only RELEASE_VERSION instea of RELEASE_VERSION, MVN_RELEASE_VERSION and PY_RELEASE_VERSION since we are not doing InPlace releases.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added devops Ingestion safe to test Add this label to run secure Github workflows on PRs labels May 9, 2024
pmbrull
pmbrull previously approved these changes May 9, 2024
pmbrull
pmbrull previously approved these changes May 10, 2024
tutte
tutte previously approved these changes May 10, 2024
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much cleaner, easier to read and to expand. Thanks @IceS2

.github/workflows/docker-openmetadata-postgres.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
.github/workflows/docker-openmetadata-server.yml Outdated Show resolved Hide resolved
@IceS2 IceS2 dismissed stale reviews from tutte and pmbrull via 22825c3 May 10, 2024 09:34
@tutte tutte merged commit b67de74 into open-metadata:main May 10, 2024
16 of 17 checks passed
@IceS2 IceS2 deleted the improve-deployment-process branch May 10, 2024 09:40
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants