Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements: Activity feed improvements #16221

Merged
merged 10 commits into from
May 11, 2024
Merged

Improvements: Activity feed improvements #16221

merged 10 commits into from
May 11, 2024

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented May 10, 2024 •
edited
Loading

Issue #13871

I worked on:

  • Improved the feed generated for data quality
Screen.Recording.2024-05-10.at.3.27.50.PM.mov
  • Improved application feeds
Screenshot 2024-05-11 at 2 14 45 PM
  • Improved Feed for teams
Screenshot 2024-05-11 at 11 08 46 AM
  • Added icon for chart asset
Screenshot 2024-05-11 at 3 05 21 PM

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label May 10, 2024
@aniketkatkar97 aniketkatkar97 requested review from a team May 10, 2024 10:19
@aniketkatkar97 aniketkatkar97 self-assigned this May 10, 2024
@github-actions github-actions bot added e2e:DataAssets backend safe to test Add this label to run secure Github workflows on PRs labels May 10, 2024
@aniketkatkar97
Fix unit tests
074a895 
Add missing tests
@cypress Cypress
Copy link

cypress bot commented May 10, 2024 •
edited
Loading

10 failed tests on run #34151 ↗︎

10 304 8 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Add icon for the chart asset
Project: openmetadata Commit: bf0c1d80f7
Status: Failed Duration: 20:14 💡
Started: May 11, 2024 9:56 AM Ended: May 11, 2024 11:16 AM

Review all test suite changes for PR #16221 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.77% (34742/53637) 41.63% (13695/32900) 43.54% (4259/9782)

chirag-madlani
chirag-madlani previously approved these changes May 10, 2024
View reviewed changes
@aniketkatkar97 aniketkatkar97 changed the title Improvements: Data quality activity feed Improvements: Activity feed improvements May 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya enabled auto-merge (squash) May 11, 2024 13:23
@Sachin-chaurasiya Sachin-chaurasiya merged commit 798fe31 into main May 11, 2024
22 of 24 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the feed-improvements branch May 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@aniketkatkar97 aniketkatkar97

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aniketkatkar97 @chirag-madlani @Sachin-chaurasiya @ShaileshParmar11