Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show run button only for schedule or manual #17327

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: show run button only for schedule or manual #17327

merged 1 commit into from
Aug 7, 2024

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Aug 7, 2024

Describe your changes:

UI changes Related to #17031

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Settings safe to test Add this label to run secure Github workflows on PRs labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.01% (36887/56741) 41.67% (14632/35110) 43.72% (4477/10241)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit 5ea7f8c into main Aug 7, 2024
17 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the app-scheduleType branch August 7, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karanh37 @Sachin-chaurasiya