Fixes #17085: Update Oracle count & unique count function to handle HexByteString/Blob types #17596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
TeddyCr
reviewed
Sep 2, 2024
Comment on lines
57
to
66
| def _unique_count_query_oracle(col, session, sample): | ||
| count_fn = col | ||
| if isinstance(col.type, HexByteString): | ||
| count_fn = CountFn(col) | ||
| return ( | ||
| session.query(func.count(count_fn)) | ||
| .select_from(sample) | ||
| .group_by(count_fn) | ||
| .having(func.count(count_fn) == 1) | ||
| ) |
There was a problem hiding this comment.
Shouldn't this be handled in the CountFn itself?
There was a problem hiding this comment.
func.count(col) gives -> 'count(propagated_msgid)'
whereas when i pass in the Countfn with custom logic for HexByteString i.e. blob as we have mapped it internally, then we get the count as count(DBMS_LOB.GETLENGTH(propagated_msgid))
we have handled it in CountFn, unique count though doesn't take CountFn, rather it uses func.count
ayush-shah
force-pushed
the
issue-17085
branch
from
3dfe1af to
ebfbfb9
Compare
|
TeddyCr
approved these changes
Sep 6, 2024
hurongliang
added a commit
to hurongliang/OpenMetadata
that referenced
this pull request
Sep 6, 2024
* main: Fixes open-metadata#17085: Update Oracle count & unique count function to handle HexByteString/Blob types (open-metadata#17596)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #17085
I worked on Updating Oracle count & unique count function to handle HexByteString/Blob types
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>