Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrated task cypress spec in Activity feed playwright #17618

Merged
merged 3 commits into from
Aug 29, 2024
Merged

migrated task cypress spec in Activity feed playwright #17618

merged 3 commits into from
Aug 29, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • I worked on Migrating Task spec in Activity feed playwright test as most of the cases are covered in that spec.
  • fix some flaky spec in activity feed spec

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Aug 28, 2024
@Ashish8689 Ashish8689 self-assigned this Aug 28, 2024
@github-actions github-actions bot added e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs labels Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.09% (37137/57058) 41.56% (14750/35487) 43.92% (4523/10299)

@Ashish8689 Ashish8689 enabled auto-merge (squash) August 28, 2024 18:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit a79a903 into main Aug 29, 2024
15 checks passed
@Ashish8689 Ashish8689 deleted the task-spec-migration branch August 29, 2024 09:42
Sachin-chaurasiya pushed a commit that referenced this pull request Aug 30, 2024
@Ashish8689 @Sachin-chaurasiya
migrated task cypress spec in Activity feed playwright (#17618)
836eec1 
(cherry picked from commit a79a903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @karanh37