Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate advanced search tests #17666

Merged
merged 9 commits into from
Sep 3, 2024
Merged

Migrate advanced search tests #17666

merged 9 commits into from
Sep 3, 2024

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Sep 2, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@karanh37 karanh37 marked this pull request as draft September 2, 2024 09:50
@github-actions github-actions bot added e2e:DataAssets UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.11% (37183/57110) 41.56% (14779/35559) 43.92% (4526/10306)

@karanh37 karanh37 marked this pull request as ready for review September 2, 2024 16:26
@karanh37 karanh37 enabled auto-merge (squash) September 2, 2024 16:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit a63ad69 into main Sep 3, 2024
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the advanced-search-tests branch September 3, 2024 13:30
karanh37 added a commit that referenced this pull request Sep 5, 2024
@karanh37
Migrate advanced search tests (#17666)
32a85c0 
* migrate advanced search tests

* verify advanced search tests

* fix minor config

* push fixes

* add before all timeout

* increase test timeout

* revert playwright config

* add rule based search

* migrate group tests

(cherry picked from commit a63ad69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanh37 @chirag-madlani @Sachin-chaurasiya