Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [DOCS] Added SAP ERP connector documentation #17668

Merged
merged 2 commits into from
Sep 4, 2024
Merged

MINOR: [DOCS] Added SAP ERP connector documentation #17668

merged 2 commits into from
Sep 4, 2024

Conversation

OnkarVO7
Copy link
Contributor

@OnkarVO7 OnkarVO7 commented Sep 2, 2024

Describe your changes:

Added SAP ERP connector documentation

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 2, 2024
@OnkarVO7 OnkarVO7 requested a review from a team September 3, 2024 05:44
SumanMaharana
SumanMaharana requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@SumanMaharana SumanMaharana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a single typo

openmetadata-docs/content/v1.5.x/connectors/database/sap-erp/index.md Outdated Show resolved Hide resolved
@notion-workspace Notion Workspace
Copy link

Validation with Swarovski and Docs

@ulixius9 ulixius9 merged commit c58b64c into main Sep 4, 2024
21 checks passed
@ulixius9 ulixius9 deleted the sap_erp_docs branch September 4, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SumanMaharana SumanMaharana SumanMaharana approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarVO7 @SumanMaharana @ulixius9