Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16644: support resizable column to customProperty #17735

Merged
merged 7 commits into from
Sep 6, 2024
Merged

#16644: support resizable column to customProperty #17735

merged 7 commits into from
Sep 6, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Sep 5, 2024 •
edited
Loading

Describe your changes:

Fixes #16644

  • I worked on support resizable column to customProperty
  • Added new library to support Table Column re-sizable
  • Mock the antd re-sizebale column library globally
Screen.Recording.2024-09-05.at.6.19.51.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 5, 2024
@Ashish8689 Ashish8689 self-assigned this Sep 5, 2024
@Ashish8689 Ashish8689 mentioned this pull request Sep 5, 2024
Closed
9 tasks
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs e2e:DataAssets labels Sep 5, 2024
@Ashish8689 Ashish8689 marked this pull request as draft September 6, 2024 05:48
@Ashish8689 Ashish8689 added e2e This will trigger e2e test workflows and removed e2e:DataAssets labels Sep 6, 2024
Sachin-chaurasiya
Sachin-chaurasiya reviewed Sep 6, 2024
View reviewed changes
openmetadata-ui/src/main/resources/ui/src/components/common/Table/table.less Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/webpack.config.dev.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashish8689 , why do we need this change, and can we update the prod webpack config as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library was using styles with .css which threw loader issue, so to fix that have included in the CSS parser here!

@cypress Cypress
Copy link

cypress bot commented Sep 6, 2024 •
edited
Loading

openmetadata    Run #34940

Run Properties:  status check errored Errored #34940  •  git commit 4c33bec609: Merge branch 'main' into column-resizable
Project openmetadata
Branch Review column-resizable
Run status status check errored Errored #34940
Run duration 12m 45s
Commit git commit 4c33bec609: Merge branch 'main' into column-resizable
Committer Ashish Gupta
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 12
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 133
View all changes introduced in this branch ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit 3d52258 into main Sep 6, 2024
18 of 20 checks passed
@Ashish8689 Ashish8689 deleted the column-resizable branch September 6, 2024 13:53
Ashish8689 added a commit that referenced this pull request Sep 6, 2024
@Ashish8689
#16644: support resizable column to customProperty (#17735)
9d73e7e 
* support resizable column to customProperty

* fix sonar by mocking react-ant-column-resize globally

* remove duplicate table less and added css loader fix in webpack config file

(cherry picked from commit 3d52258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support flex column for custom property view
3 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya