Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate recently viewed spec to playwright #17741

Merged
merged 7 commits into from
Sep 6, 2024
Merged

test: migrate recently viewed spec to playwright #17741

merged 7 commits into from
Sep 6, 2024

Conversation

Sachin-chaurasiya
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Sep 5, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.11% (37181/57108) 41.6% (14790/35557) 43.93% (4527/10306)

chirag-madlani
chirag-madlani previously approved these changes Sep 5, 2024
View reviewed changes
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as draft September 6, 2024 08:23
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review September 6, 2024 08:47
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review September 6, 2024 14:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit 8568eaf into main Sep 6, 2024
17 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the migrate-recentlyviewed-cy-pw branch September 6, 2024 15:50
Sachin-chaurasiya added a commit that referenced this pull request Sep 11, 2024
@Sachin-chaurasiya
test: migrate recently viewed spec to playwright (#17741)
cee82c8 
(cherry picked from commit 8568eaf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachin-chaurasiya @chirag-madlani