Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cypress for the Customize Landing and EntityVersion page #17744

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix cypress for the Customize Landing and EntityVersion page #17744

merged 1 commit into from
Sep 6, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes

  • Fix cypress for the Customize Landing
  • Fix breaking of entity version page, due to empty oldText or newText

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 6, 2024
@Ashish8689 Ashish8689 self-assigned this Sep 6, 2024
@Ashish8689 Ashish8689 added the e2e This will trigger e2e test workflows label Sep 6, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.1% (37169/57096) 41.58% (14781/35547) 43.91% (4524/10303)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Sep 6, 2024

openmetadata    Run #34938

Run Properties:  status check errored Errored #34938  •  git commit b7f30108bb: fix cypress for the Customzie Landing and EntityVersion page
Project openmetadata
Branch Review entity-vesion-page-fix
Run status status check errored Errored #34938
Run duration 11m 21s
Commit git commit b7f30108bb: fix cypress for the Customzie Landing and EntityVersion page
Committer Ashish Gupta
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 12
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 133
View all changes introduced in this branch ↗︎

@chirag-madlani chirag-madlani merged commit dcad829 into main Sep 6, 2024
32 of 42 checks passed
@chirag-madlani chirag-madlani deleted the entity-vesion-page-fix branch September 6, 2024 11:23
Ashish8689 added a commit that referenced this pull request Sep 6, 2024
@Ashish8689
fix cypress for the Customzie Landing and EntityVersion page (#17744)
c6a7aae 
(cherry picked from commit dcad829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya @ShaileshParmar11