Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: added config logging with secrets redacted #17770

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Sep 9, 2024

Describe your changes:

Redo #17464 but redact secrets from the config so they are safe to publish.

This allows to validate which config is running with a specific workflow instance.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

@pmbrull pmbrull disabled auto-merge September 12, 2024 08:19
@pmbrull pmbrull merged commit b70b3ce into main Sep 12, 2024
12 of 16 checks passed
@pmbrull pmbrull deleted the print-redacted-config-logs branch September 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants