Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Templates for Slack, GChat, and MSTeams #17771

Merged
merged 63 commits into from
Nov 11, 2024
Merged

Improve Templates for Slack, GChat, and MSTeams #17771

merged 63 commits into from
Nov 11, 2024

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Sep 9, 2024 •
edited
Loading

Describe your changes:

Fixes: #17717
Creating new templates for alerts and notifications for Slack, GChat and MSTeams.

  1. For DQ alerts
  2. For destination tests
  3. For general ChangeEvent alerts

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Sep 9, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Sep 9, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team as a code owner September 9, 2024 13:21
@Siddhanttimeline Siddhanttimeline marked this pull request as draft September 11, 2024 05:25
@Siddhanttimeline
Merge branch 'main' into improvements-slack-alert-templates
61b4fb1 
# Conflicts:
#	openmetadata-service/src/main/java/org/openmetadata/service/formatter/decorators/SlackMessageDecorator.java
@Siddhanttimeline
fix conflict
2a4383d
@Siddhanttimeline Siddhanttimeline marked this pull request as draft November 9, 2024 14:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Siddhanttimeline Siddhanttimeline marked this pull request as ready for review November 10, 2024 08:32
@Siddhanttimeline Siddhanttimeline changed the title [WIP] Improve Templates for Slack, GChat, and MSTeams Improve Templates for Slack, GChat, and MSTeams Nov 10, 2024
@Siddhanttimeline Siddhanttimeline merged commit 2437d01 into main Nov 11, 2024
18 checks passed
@Siddhanttimeline Siddhanttimeline deleted the improvements-slack-alert-templates branch November 11, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Slack Templates
2 participants
@Siddhanttimeline @mohityadav766