Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: improve UI of filters in test case graph #17775

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Minor: improve UI of filters in test case graph #17775

merged 4 commits into from
Sep 12, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Sep 10, 2024 •
edited
Loading

Minor: improve UI of filters in test case graph

Screen.Recording.2024-09-10.at.12.59.20.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Sep 10, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Sep 10, 2024
@ShaileshParmar11 ShaileshParmar11 added the e2e This will trigger e2e test workflows label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.12% (37225/57161) 41.62% (14809/35584) 43.93% (4529/10309)

@cypress Cypress
Copy link

cypress bot commented Sep 10, 2024 •
edited
Loading

openmetadata    Run #34947

Run Properties:  status check passed Passed #34947  •  git commit acb8ee3e0a: Merge branch 'main' into test-case-graph-filter-ui-change
Project openmetadata
Branch Review test-case-graph-filter-ui-change
Run status status check passed Passed #34947
Run duration 05m 42s
Commit git commit acb8ee3e0a: Merge branch 'main' into test-case-graph-filter-ui-change
Committer Shailesh Parmar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 12
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 46
View all changes introduced in this branch ↗︎

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) September 10, 2024 10:32
@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) September 11, 2024 11:04
@ShaileshParmar11 ShaileshParmar11 merged commit d785276 into main Sep 12, 2024
16 of 17 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the test-case-graph-filter-ui-change branch September 12, 2024 14:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani