Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - Add ES pagination with error handling #17776

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Sep 10, 2024

Describe your changes:

Required to fix the automator iteration.
We initially thought it might come due to limits on ES, but we're actually paginating the data. -> Data was not properly paginated. WE got that sorted out via the search_after param.

Another issue was when we were stopping the iteration when encountering errors getting the entities which killed the pagination process

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

Automator ES Limit

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 10, 2024
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

@pmbrull pmbrull merged commit f4d0eba into open-metadata:main Sep 12, 2024
19 of 20 checks passed
@pmbrull pmbrull deleted the lineage-pagination-fix branch September 12, 2024 05:14
pmbrull added a commit that referenced this pull request Sep 12, 2024
* MINOR - Add ES pagination with error handling

* format

* format

* add nullable

* prepare API

* fix pagination

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants