-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR - Add ES pagination with error handling #17776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
Add this label to run secure Github workflows on PRs
labels
Sep 10, 2024
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
sushi30
approved these changes
Sep 11, 2024
pmbrull
added a commit
that referenced
this pull request
Sep 12, 2024
* MINOR - Add ES pagination with error handling * format * format * add nullable * prepare API * fix pagination * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Required to fix the automator iteration.
We initially thought it might come due to limits on ES, but we're actually paginating the data. -> Data was not properly paginated. WE got that sorted out via thesearch_after
param.Another issue was when we were stopping the iteration when encountering errors getting the entities which killed the pagination process
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>