Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated team-drag-drop spec in playwright #17780

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.12% (37219/57152) 41.61% (14804/35575) 43.94% (4529/10308)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate if we are using this function any where else or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have validated that and we aren't using it anywhere else

Copy link

Copy link

cypress bot commented Sep 10, 2024

openmetadata    Run #34944

Run Properties:  status check passed Passed #34944  •  git commit 00b9e8ad7d: Merge branch 'main' into teams-drag-drop-migration
Project openmetadata
Branch Review teams-drag-drop-migration
Run status status check passed Passed #34944
Run duration 08m 51s
Commit git commit 00b9e8ad7d: Merge branch 'main' into teams-drag-drop-migration
Committer Ashish Gupta
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 12
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 46
View all changes introduced in this branch ↗︎

@Ashish8689 Ashish8689 enabled auto-merge (squash) September 10, 2024 15:03
@Ashish8689 Ashish8689 merged commit 5cb897f into main Sep 11, 2024
19 checks passed
@Ashish8689 Ashish8689 deleted the teams-drag-drop-migration branch September 11, 2024 07:27
Ashish8689 added a commit that referenced this pull request Sep 11, 2024
* migrated team-drag-drop spec in playwright

* remove the cypress file since the migration is done

(cherry picked from commit 5cb897f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants