Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playwright: migrate permission spec to playwright #17795

Merged
merged 12 commits into from
Sep 13, 2024
Merged

playwright: migrate permission spec to playwright #17795

merged 12 commits into from
Sep 13, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Sep 11, 2024 •
edited
Loading

migrated permission spec from cypress to playwright

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.12% (37226/57162) 41.61% (14807/35582) 43.93% (4529/10309)

@ShaileshParmar11 ShaileshParmar11 self-assigned this Sep 12, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review September 12, 2024 14:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 merged commit 0e75a9c into main Sep 13, 2024
16 of 17 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the pw-remove-org-policies branch September 13, 2024 05:54
ShaileshParmar11 added a commit that referenced this pull request Sep 16, 2024
@ShaileshParmar11 @chirag-madlani
playwright: migrate permission spec to playwright (#17795)
6049ef6 
* playwright: remove organisation policy and role before staring the playwright test

* added default role as data consumer

* fixed failing test

* keeping org policies as it is.

* migrate permission spec

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani