Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: move constraint update from schemaChanges to postDataMigration #17801

Merged
merged 2 commits into from
Sep 12, 2024
Merged

MINOR: move constraint update from schemaChanges to postDataMigration #17801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dffc10
fix: move constraint update from schemaChanges to postDataMigration
TeddyCr Sep 11, 2024
c5adb41
fix: move index after column is created
TeddyCr Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bootstrap/sql/migrations/native/1.6.0/mysql/postDataMigrationSQLScript.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,13 @@ INNER JOIN test_case tc ON dqdts.entityFQNHash = tc.fqnHash
SET dqdts.json = JSON_SET(dqdts.json,
'$.testCaseFQN', tc.json->'$.fullyQualifiedName',
'$.id', (SELECT UUID())
);
);

-- Add id column to data_quality_data_time_series table
-- after we have added the id values to the records
ALTER TABLE data_quality_data_time_series
ADD COLUMN id VARCHAR(36) GENERATED ALWAYS AS (json ->> '$.id') STORED NOT NULL,
ADD CONSTRAINT UNIQUE (id);

-- Create index on id column
CREATE INDEX data_quality_data_time_series_id_index ON data_quality_data_time_series (id);
5 changes: 0 additions & 5 deletions bootstrap/sql/migrations/native/1.6.0/mysql/schemaChanges.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +0,0 @@
ALTER TABLE data_quality_data_time_series
ADD COLUMN id VARCHAR(36) GENERATED ALWAYS AS (json ->> '$.id') STORED NOT NULL,
ADD CONSTRAINT UNIQUE (id);

CREATE INDEX data_quality_data_time_series_id_index ON data_quality_data_time_series (id);
9 changes: 9 additions & 0 deletions bootstrap/sql/migrations/native/1.6.0/postgres/postDataMigrationSQLScript.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,12 @@ SET json = jsonb_set(
)
FROM test_case tc
WHERE dqdts.entityfqnHash = tc.fqnHash;

-- Add id column to data_quality_data_time_series table
-- after we have added the id values to the records
ALTER TABLE data_quality_data_time_series
ADD COLUMN id VARCHAR(36) GENERATED ALWAYS AS (json ->> 'id') STORED,
ADD CONSTRAINT id_unique UNIQUE (id);

-- Create index on id column
CREATE INDEX IF NOT EXISTS data_quality_data_time_series_id_index ON data_quality_data_time_series (id);
5 changes: 0 additions & 5 deletions bootstrap/sql/migrations/native/1.6.0/postgres/schemaChanges.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +0,0 @@
ALTER TABLE data_quality_data_time_series
ADD COLUMN id VARCHAR(36) GENERATED ALWAYS AS (json ->> 'id') STORED,
ADD CONSTRAINT id_unique UNIQUE (id);

CREATE INDEX IF NOT EXISTS data_quality_data_time_series_id_index ON data_quality_data_time_series (id);
Loading