migration: fully migrated customize landing page to playwright #17803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashish8689
requested review from
ShaileshParmar11,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
github-actions
bot
added
e2e:DataAssets
safe to test
Jest test CoverageUI tests summary
|
There was a problem hiding this comment.
Make sure we are not using the utils any where else
There was a problem hiding this comment.
yes, we aren't using this anywhere else
openmetadata-ui/src/main/resources/ui/playwright/utils/customizeLandingPage.ts
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/customizeLandingPage.ts
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/customizeLandingPage.ts
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/customizeLandingPage.ts
Outdated
Show resolved
Hide resolved
|
@ShaileshParmar11 changes made as per comments! |
ShaileshParmar11
approved these changes
Sep 11, 2024
|
ShaileshParmar11
pushed a commit
that referenced
this pull request
Sep 16, 2024
* fully migrated customize landing page to playwright * changes made as per comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on migrating customize landing page to playwright
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>