Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17804: Classification API returns Table class for restore #17806

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fixes #17804: Classification API returns Table class for restore #17806

merged 2 commits into from
Sep 12, 2024

Conversation

ayush-shah
Copy link
Member

@ayush-shah ayush-shah commented Sep 11, 2024 •
edited
Loading

Describe your changes:

Fixes #17804

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ayush-shah ayush-shah changed the title fix: Classification API returns Table class for restore Fixes #17804: Classification API returns Table class for restore Sep 11, 2024
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@notion-workspace Notion Workspace
Copy link

Backend: Restore a soft deleted classification returns Table

@ayush-shah ayush-shah marked this pull request as ready for review September 11, 2024 11:20
@ayush-shah ayush-shah requested a review from a team as a code owner September 11, 2024 11:20
@ayush-shah ayush-shah merged commit 1c6695b into main Sep 12, 2024
14 of 24 checks passed
@ayush-shah ayush-shah deleted the issue-17804 branch September 12, 2024 04:41
ayush-shah added a commit that referenced this pull request Sep 12, 2024
@ayush-shah
Fixes #17804: Classification API returns Table class for restore (#17806
620a690 
)

* fix: Classification API returns Table class for restore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend: Restore a soft deleted classification returns Table
2 participants
@ayush-shah @harshach