Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrated myData spec to playwright #17808

Merged
merged 2 commits into from
Sep 11, 2024
Merged

migrated myData spec to playwright #17808

merged 2 commits into from
Sep 11, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • I worked on migrated myData spec to playwright.

Note :

  • Have not migrated the last 2 skipped tests, as they only check the feed after updating the owner in the entities, which Backed generates.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 11, 2024
@Ashish8689 Ashish8689 self-assigned this Sep 11, 2024
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs and removed e2e:DataAssets labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.12% (37224/57160) 41.61% (14804/35578) 43.93% (4529/10309)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit fd2b080 into main Sep 11, 2024
26 of 33 checks passed
@Ashish8689 Ashish8689 deleted the my-data-playwright-migration branch September 11, 2024 13:28
Ashish8689 added a commit that referenced this pull request Sep 11, 2024
@Ashish8689
migrated myData spec to playwright (#17808)
291dea2 
* migrated myData spec to playwright

* remove unwanted test block

(cherry picked from commit fd2b080)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @ShaileshParmar11