Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fix Redshift View Def regex_replace Error #17810

Merged
merged 2 commits into from
Sep 11, 2024
Merged

MINOR: Fix Redshift View Def regex_replace Error #17810

merged 2 commits into from
Sep 11, 2024

Conversation

ulixius9
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ulixius9 ulixius9 requested a review from a team as a code owner September 11, 2024 14:10
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 11, 2024
harshsoni2024
harshsoni2024 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@harshsoni2024 harshsoni2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ingestion looks good with no schema binding view.

@ulixius9 ulixius9 merged commit 4544676 into main Sep 11, 2024
11 of 17 checks passed
@ulixius9 ulixius9 deleted the redshift_view_def_fix branch September 11, 2024 15:32
ulixius9 added a commit that referenced this pull request Sep 11, 2024
@ulixius9
MINOR: Fix Redshift View Def regex_replace Error (#17810)
11b7d14
ulixius9 added a commit that referenced this pull request Sep 11, 2024
@ulixius9
MINOR: Fix Redshift View Def regex_replace Error (#17810)
e23a18b
@ulixius9 ulixius9 mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshsoni2024 harshsoni2024 harshsoni2024 approved these changes

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulixius9 @harshach @harshsoni2024