Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: ci: pin spacy version #17814

Merged
merged 1 commit into from
Sep 12, 2024
Merged

MINOR: ci: pin spacy version #17814

merged 1 commit into from
Sep 12, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Sep 12, 2024

spacy 3.8 requires numpy 2.0 which is not compatible with openmetadata-ingestion requirements: explosion/spaCy@184e508

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

spacy 3.8 requires numpy 2.0 which is not compatible with openmetadata-ingestion requirements:
explosion/spaCy@184e508
Copy link

@mohityadav766 mohityadav766 merged commit 3282b05 into main Sep 12, 2024
16 of 18 checks passed
@mohityadav766 mohityadav766 deleted the pin-spacy branch September 12, 2024 09:42
sushi30 added a commit that referenced this pull request Sep 20, 2024
spacy 3.8 requires numpy 2.0 which is not compatible with openmetadata-ingestion requirements:
explosion/spaCy@184e508

(cherry picked from commit 3282b05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants