Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playwright: fixed failing aut test in main #17818

Merged
merged 4 commits into from
Sep 12, 2024
Merged

playwright: fixed failing aut test in main #17818

merged 4 commits into from
Sep 12, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Sep 12, 2024 •
edited by Ashish8689
Loading

Describe your changes:

fixed failing playwright test of AUT

  • Added fix for MyData spec failure

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Integration e2e:Governance e2e:DataAssets e2e:Settings safe to test Add this label to run secure Github workflows on PRs and removed UI UI specific issues labels Sep 12, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.12% (37226/57162) 41.62% (14809/35584) 43.93% (4529/10309)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit fda7e1e into main Sep 12, 2024
17 checks passed
@Ashish8689 Ashish8689 deleted the fixed-failing-aut-main branch September 12, 2024 18:12
karanh37 pushed a commit that referenced this pull request Sep 12, 2024
@ShaileshParmar11 @karanh37
playwright: fixed failing aut test in main (#17818)
ebebe42 
* playwright: fixed failing aut test in main

* fix myData spec failure

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
(cherry picked from commit fda7e1e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e:Governance e2e:Integration e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaileshParmar11 @chirag-madlani @Ashish8689