Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 8428: make it possible to choice a sampling method type when we create profile ingestion for the Snowflake #17831

Merged
merged 13 commits into from
Sep 15, 2024

Conversation

nakaken-churadata
Copy link
Contributor

Describe your changes:

Fixes 8428

I worked on that we can choice a sampling method type when we create a profiler ingestion for Snowflake because the current sampling method type, i.e BERNOULLI, occurs full table scan even though we use small sampling rate.
I created new test code for adding sampling method type.

By the way, I wrote some description in this PR but I'm not at good for English. I feel happy if someone review my writing :D

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added documentation Improvements or additions to documentation UI UI specific issues Ingestion backend spec labels Sep 13, 2024
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

Copy link

@TeddyCr TeddyCr merged commit 3d8e301 into open-metadata:main Sep 15, 2024
35 of 36 checks passed
@nakaken-churadata
Copy link
Contributor Author

close #8428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs spec UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants