-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 8428: make it possible to choice a sampling method type when we create profile ingestion for the Snowflake #17831
Conversation
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
close #8428 |
Describe your changes:
Fixes 8428
I worked on that we can choice a sampling method type when we create a profiler ingestion for Snowflake because the current sampling method type, i.e
BERNOULLI
, occurs full table scan even though we use small sampling rate.I created new test code for adding
sampling method type
.By the way, I wrote some description in this PR but I'm not at good for English. I feel happy if someone review my writing :D
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>