Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sigma Dashboard Connector #17855

Merged
merged 29 commits into from
Sep 26, 2024
Merged

Add Sigma Dashboard Connector #17855

merged 29 commits into from
Sep 26, 2024

Conversation

SumanMaharana
Copy link
Contributor

Describe your changes:

Added Sigma Dashboard Connector

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Sep 16, 2024
@notion-workspace Notion Workspace
Copy link

Sigma Dashboard

pmbrull
pmbrull requested changes Sep 16, 2024
View reviewed changes
ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/sigma/models.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/sigma/metadata.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SumanMaharana SumanMaharana merged commit 37b6dc8 into open-metadata:main Sep 26, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@pmbrull pmbrull pmbrull approved these changes

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SumanMaharana @OnkarVO7 @pmbrull @ShaileshParmar11