Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-706 Feat: Introducing incident tab in table details page #17860

Merged
merged 9 commits into from
Sep 24, 2024
Merged

GEN-706 Feat: Introducing incident tab in table details page #17860

merged 9 commits into from
Sep 24, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Sep 16, 2024 •
edited
Loading

Describe your changes:

fixed GEN-706
fixes #16247

I worked on adding incident tab in the table details page.

image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.35% (37409/58138) 41.01% (14840/36182) 43.09% (4512/10470)

@ShaileshParmar11 ShaileshParmar11 changed the title Feat: Introducing incident tab in table details page GEN-706 Feat: Introducing incident tab in table details page Sep 23, 2024
@notion-workspace Notion Workspace
Copy link

Add Incident tab on entity page & list incidents on lineage entity side pane

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit a014f5c into main Sep 24, 2024
17 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the incidnet-tab-entity-details-page branch September 24, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Incident tab on entity page & list incidents on lineage entity side pane
2 participants
@ShaileshParmar11 @Sachin-chaurasiya