-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Teams and owner fields are not being passed in the policy API call. #17880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 07:50 — with
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 07:50 — with
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 07:50 — with
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 07:50 — with
GitHub Actions
Error
github-actions
bot
added
safe to test
Add this label to run secure Github workflows on PRs
UI
UI specific issues
labels
Sep 17, 2024
Sachin-chaurasiya
temporarily deployed
to
test
September 17, 2024 07:51 — with
GitHub Actions
Inactive
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 07:51 — with
GitHub Actions
Failure
Sachin-chaurasiya
temporarily deployed
to
test
September 17, 2024 07:51 — with
GitHub Actions
Inactive
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 07:51 — with
GitHub Actions
Failure
Sachin-chaurasiya
requested review from
ShaileshParmar11,
karanh37 and
chirag-madlani
as code owners
September 17, 2024 09:19
Sachin-chaurasiya
temporarily deployed
to
test
September 17, 2024 09:19 — with
GitHub Actions
Inactive
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 09:19 — with
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 09:19 — with
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 09:19 — with
GitHub Actions
Failure
chirag-madlani
approved these changes
Sep 17, 2024
Sachin-chaurasiya
temporarily deployed
to
test
September 17, 2024 10:38 — with
GitHub Actions
Inactive
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 10:38 — with
GitHub Actions
Failure
Sachin-chaurasiya
temporarily deployed
to
test
September 17, 2024 10:38 — with
GitHub Actions
Inactive
Sachin-chaurasiya
temporarily deployed
to
test
September 17, 2024 10:38 — with
GitHub Actions
Inactive
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 13:49 — with
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
September 17, 2024 14:52 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
The issue lies in the way the fields are being passed to the
getPolicyByName
function. The expression inside the template literal is using the comma operator, which only evaluates the last operand. Therefore, onlyTabSpecificField.ROLES
is being passed.Was introduced in #17013
To fix the issue now we are passing fields like this
Screen.Recording.2024-09-17.at.1.15.11.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>