Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix the flakiness in observabilityAlert and EntityDataConsumer specs #17899

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Minor: Fix the flakiness in observabilityAlert and EntityDataConsumer specs #17899

merged 3 commits into from
Sep 20, 2024

Conversation

aniketkatkar97
Copy link
Member

I worked on fixing the flakiness in observabilityAlert and EntityDataConsumer specs

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues e2e This will trigger e2e test workflows labels Sep 18, 2024
@aniketkatkar97 aniketkatkar97 self-assigned this Sep 18, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.31% (37352/58080) 40.96% (14784/36096) 43.07% (4507/10465)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@aniketkatkar97 aniketkatkar97 merged commit 564c16b into main Sep 20, 2024
16 checks passed
@aniketkatkar97 aniketkatkar97 deleted the fix-flaky-playwright branch September 20, 2024 09:33
aniketkatkar97 added a commit that referenced this pull request Sep 20, 2024
@aniketkatkar97
Fix the flakiness in observabilityAlert and EntityDataConsumer specs (#…
310d5e9 
…17899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@aniketkatkar97 aniketkatkar97

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketkatkar97 @ShaileshParmar11