Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-16487] Add Stop for Search Indexing #17914

Merged
merged 8 commits into from
Sep 25, 2024
Merged

[Issue-16487] Add Stop for Search Indexing #17914

merged 8 commits into from
Sep 25, 2024

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Sep 18, 2024

Describe your changes:

Fixes #16487

  • Allow Jobs to be stopped

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

@sushi30 sushi30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline comments. Can we add a test for this functionality?

@mohityadav766
Copy link
Contributor Author

Some inline comments. Can we add a test for this functionality?

addressed

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

sushi30
sushi30 previously approved these changes Sep 23, 2024
Copy link

@mohityadav766 mohityadav766 merged commit afd7887 into main Sep 25, 2024
21 of 23 checks passed
@mohityadav766 mohityadav766 deleted the allow-run-stop branch September 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SearchINdexing] Allow App run to be stopped while current run is going on
3 participants