Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16465 : supported glossary table column resizable #17918

Merged
merged 10 commits into from
Jan 3, 2025
Merged

#16465 : supported glossary table column resizable #17918

merged 10 commits into from
Jan 3, 2025

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Sep 19, 2024 •
edited
Loading

Describe your changes:

Fixes #16465

  • I worked on supporting resizeable column in glossary tables

Note :

  • For each table the last column should not have any width, so while re-sizing any column it should not affect width of other columns.
Screen.Recording.2024-12-24.at.6.45.41.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 19, 2024
@Ashish8689 Ashish8689 self-assigned this Sep 19, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.51% (40587/62912) 40.76% (16255/39880) 43.86% (4915/11206)

@Ashish8689 Ashish8689 marked this pull request as ready for review December 24, 2024 13:14
@Ashish8689 Ashish8689 requested a review from a team as a code owner December 24, 2024 13:14
chirag-madlani
chirag-madlani reviewed Jan 2, 2025
View reviewed changes
.../src/main/resources/ui/src/components/Glossary/GlossaryTermTab/GlossaryTermTab.component.tsx
Comment on lines +247 to +249
...(permissions.Create && {
width: 100,
}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There won't be any width if create permission is not there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, so to maintain that the last column, should not have width where the re-sizeable table is there.

@Ashish8689 Ashish8689 enabled auto-merge (squash) January 2, 2025 18:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit 87c07f3 into main Jan 3, 2025
17 checks passed
@Ashish8689 Ashish8689 deleted the glossary-table-resizable branch January 3, 2025 04:39
Ashish8689 added a commit that referenced this pull request Jan 3, 2025
@Ashish8689
#16465 : supported glossary table column resizable (#17918)
7951156 
* supported glossary table column resizable

* code cleanup

* fix the column resizing affecting other column width

* fix the playwright failure around the glossary due to re-sizable added

(cherry picked from commit 87c07f3)
chirag-madlani pushed a commit that referenced this pull request Jan 3, 2025
@Ashish8689 @chirag-madlani
#16465 : supported glossary table column resizable (#17918)
d266c0c 
* supported glossary table column resizable

* code cleanup

* fix the column resizing affecting other column width

* fix the playwright failure around the glossary due to re-sizable added

(cherry picked from commit 87c07f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glossary page UI improvement - more space for description
2 participants
@Ashish8689 @chirag-madlani